Issue 4826049: local host set incorrectly in dial

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(254)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4826049: local host set incorrectly in dial

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by jani.lahtinen8

Modified:
2 years, 2 months ago

Reviewers:
rsc

CC:
rsc, codebot

Visibility:
Public.

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
M	src/lib9/dial.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

jani.lahtinen8

14 years, 5 months ago (2011年07月28日 12:09:17 UTC) #1

rsc

LGTM thanks

14 years, 4 months ago (2011年08月16日 18:01:45 UTC) #2

LGTM
thanks

rsc

*** Submitted as 1c77f68af39c *** lib9: fix local addr in dial R=rsc CC=plan9port.codebot http://codereview.appspot.com/4826049 Committer: ...

14 years, 4 months ago (2011年08月16日 18:02:17 UTC) #3

*** Submitted as 1c77f68af39c ***
lib9: fix local addr in dial
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/4826049
Committer: Russ Cox <rsc@swtch.com>