Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4682045: code review 4682045: fmt: detect implied zero-precision field width

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by mtj
Modified:
14 years, 6 months ago
Reviewers:
r, gri , golang-dev
CC:
golang-dev, r2
Visibility:
Public.
fmt: detect implied zero-precision field width Printf formatting in the C library tradition allows an isolated period to specify a zero precision, so that "%5.0f" and "%5.f" have the same meaning. Also, the any width but no fractional digits "%.0f" and "%.f" are equivalent. It looks funny but seems to be universally supported. I've changed the approprate code in print.c so that once the period is seen the precision flag is set and the width is zero unless further digits are provided.

Patch Set 1 #

Patch Set 2 : diff -r d847323c0fbf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r aa01a846e2b2 https://go.googlecode.com/hg/ #

Created: 14 years, 6 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/fmt/print.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
Total messages: 3
|
mtj
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, r@google.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 6 months ago (2011年07月08日 15:23:00 UTC) #1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
r@google.com),
I'd like you to review this change to
https://go.googlecode.com/hg/ 
Sign in to reply to this message.
gri
LGTM, leaving for r.
14 years, 6 months ago (2011年07月11日 20:19:51 UTC) #2
LGTM, leaving for r.
Sign in to reply to this message.
r
still waiting for a relevant test case.
14 years, 6 months ago (2011年07月12日 04:00:19 UTC) #3
still waiting for a relevant test case.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /