Issue 4681041: Integrated ship control into helmsman main

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

(147)

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by grund(helms-)mann

Modified:
14 years, 6 months ago

Reviewers:
lvd

CC:
avalonsailing_googlegroups.com

Base URL:
http://avalonsailing.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -65 lines)			Patch
M	helmsman/controller_io.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	helmsman/helmsman_main.cc	View	15 chunks	+54 lines, -42 lines	0 comments	Download
M	helmsman/normal_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	helmsman/normal_controller_test.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	helmsman/sampling_period.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	helmsman/simulate_ship_normal_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	helmsman/simulate_ship_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filter/wrap_around_filter_test.cc	View	3 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 3

grund(helms-)mann

14 years, 6 months ago (2011年07月07日 07:59:18 UTC) #1

lvd

lgtm

14 years, 6 months ago (2011年07月07日 08:00:36 UTC) #2

lgtm

grund(helms-)mann

On 2011年07月07日 08:00:36, lvd wrote: > lgtm LGTM

14 years, 6 months ago (2011年07月11日 06:25:40 UTC) #3

On 2011年07月07日 08:00:36, lvd wrote:
> lgtm
LGTM