|
|
|
Created:
14 years, 6 months ago by Steve VanDeBogart Modified:
14 years, 6 months ago Reviewers:
reed1 CC:
skia-review_googlegroups.com Base URL:
https://skia.googlecode.com/svn/trunk Visibility:
Public. |
[PDF] Update PDF shader code in the same way as r1684.
Patch Set 1 #Patch Set 2 : Address comments #Total messages: 6
|
Steve VanDeBogart
Mike, how did you test your change in 1684? Will setting both radii in gm/gradients.cpp ...
|
14 years, 6 months ago (2011年06月25日 01:31:01 UTC) #1 |
Mike, how did you test your change in 1684? Will setting both radii in gm/gradients.cpp trigger the condition? I could slog through the math again, but if you remember....
Perhaps we can keep the check for a the samein both cases: either both test a ==
0 or both tests a != 0, just to make it easier to see that its really 2
different equations (quad and linear), but with common code in the middle.
2. Try using string.appendf("%d %d roll min max etc");
This will allow you to put more of the logic in a single line, making it easier
to follow sometimes.
On 2011年06月27日 13:14:48, reed1 wrote:
> Perhaps we can keep the check for a the samein both cases: either both test a
==
> 0 or both tests a != 0, just to make it easier to see that its really 2
Done.
> different equations (quad and linear), but with common code in the middle.
>
> 2. Try using string.appendf("%d %d roll min max etc");
>
> This will allow you to put more of the logic in a single line, making it
easier
> to follow sometimes.
Done.
I just have have to figure out a test...
I'll submit a test soon (need it for the gpu case as well) On Mon, Jun 27, 2011 at 1:37 PM, <vandebo@chromium.org> wrote: > On 2011年06月27日 13:14:48, reed1 wrote: >> >> Perhaps we can keep the check for a the samein both cases: either both > > test a == >> >> 0 or both tests a != 0, just to make it easier to see that its really > > 2 > > Done. > >> different equations (quad and linear), but with common code in the > > middle. > >> 2. Try using string.appendf("%d %d roll min max etc"); > >> This will allow you to put more of the logic in a single line, making > > it easier >> >> to follow sometimes. > > Done. > > I just have have to figure out a test... > > http://codereview.appspot.com/4662054/ >
gm/gradients.cpp has been updated with gradients_degenerate_2pt On Mon, Jun 27, 2011 at 1:40 PM, Mike Reed <reed@google.com> wrote: > I'll submit a test soon (need it for the gpu case as well) > > On Mon, Jun 27, 2011 at 1:37 PM, <vandebo@chromium.org> wrote: >> On 2011年06月27日 13:14:48, reed1 wrote: >>> >>> Perhaps we can keep the check for a the samein both cases: either both >> >> test a == >>> >>> 0 or both tests a != 0, just to make it easier to see that its really >> >> 2 >> >> Done. >> >>> different equations (quad and linear), but with common code in the >> >> middle. >> >>> 2. Try using string.appendf("%d %d roll min max etc"); >> >>> This will allow you to put more of the logic in a single line, making >> >> it easier >>> >>> to follow sometimes. >> >> Done. >> >> I just have have to figure out a test... >> >> http://codereview.appspot.com/4662054/ >> >
On 2011年06月27日 18:12:05, reed1 wrote: > gm/gradients.cpp has been updated with gradients_degenerate_2pt Thanks, that helps. For some reason the PDF code has the colors backward and I don't see why. I have to come back to this later.