|
|
|
Created:
14 years, 6 months ago by gjredelinghuys Modified:
14 years, 6 months ago Reviewers:
agl1 CC:
golang-dev, r2, agl1 Visibility:
Public. |
crypto/openpgp: fixed dangerous use of for loop variable
In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned
to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position.
Patch Set 1 #Patch Set 2 : diff -r bb79fe092dda https://go.googlecode.com/hg/ #Patch Set 3 : diff -r bb79fe092dda https://go.googlecode.com/hg/ #Patch Set 4 : diff -r bb79fe092dda https://go.googlecode.com/hg/ #Total messages: 8
|
gjredelinghuys
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
|
14 years, 6 months ago (2011年07月05日 09:31:26 UTC) #1 |
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
Thanks. This is such a small CL it might not be worth your trouble to do the license assignment stuff to be an official contributor to the Go project. If you'd like to do that, by all means do so, but if not, I'd be happy to make and commit these changes for you. -rob
I'm planning on using Google Go for a long time to come, so I think I'd like to go through the license assignment stuff :). Where do I start (not able to find a link on any of Google Go pages) ? On 5 July 2011 11:35, Rob 'Commander' Pike <r@google.com> wrote: > Thanks. This is such a small CL it might not be worth your trouble to do > the license assignment stuff to be an official contributor to the Go > project. If you'd like to do that, by all means do so, but if not, I'd be > happy to make and commit these changes for you. > > -rob > >
On 05/07/2011, at 7:41 PM, Gideon Redelinghuys wrote: > I'm planning on using Google Go for a long time to come, so I think I'd like to go through the license assignment stuff :). Where do I start (not able to find a link on any of Google Go pages) ? Follow the instructions at http://golang.org/doc/contribute.html, and be sure to read the section on Copyright. -rob
On Tue, Jul 5, 2011 at 5:31 AM, <gjredelinghuys@gmail.com> wrote: > crypto/openpgp: fixed dangerous use of for loop variable The bug is that there's no break after "md.SignedBy = "..., so please put that in. I'm also happy with not taking a pointer to the loop variable so changing the RHS to &keys[i] is still good. Cheers AGL
Hello golang-dev@googlegroups.com, r@google.com, agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
LGTM
*** Submitted as http://code.google.com/p/go/source/detail?r=e75c257edeb9 *** crypto/openpgp: fixed dangerous use of for loop variable In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position. R=golang-dev, r, agl CC=golang-dev http://codereview.appspot.com/4631088 Committer: Rob Pike <r@golang.org>