Issue 4532045: code review 4532045: gc: fix type switch error message for invalid cases.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(136)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4532045: code review 4532045: gc: fix type switch error message for invalid cases.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by lstoakes

Modified:
2 years, 2 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

gc: fix type switch error message for invalid cases. Fixes issue 1606.

Patch Set 1 #

Patch Set 2 : diff -r f39664db2e15 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f39664db2e15 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3556fc4657a3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3556fc4657a3 https://go.googlecode.com/hg/ #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
M	src/cmd/gc/swt.c	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
A	test/fixedbugs/bug340.go	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 4

lstoakes

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 8 months ago (2011年05月10日 05:24:45 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/

rsc

LGTM please run hg gofmt; hg mail

14 years, 8 months ago (2011年05月11日 15:56:54 UTC) #2

LGTM
please run hg gofmt; hg mail

lstoakes

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 8 months ago (2011年05月11日 17:05:43 UTC) #3

Hello rsc (cc: golang-dev@googlegroups.com),
Please take another look.

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=1bad75771eb6 *** gc: fix type switch error message for invalid cases. Fixes ...

14 years, 8 months ago (2011年05月12日 03:42:03 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=1bad75771eb6 ***
gc: fix type switch error message for invalid cases.
Fixes issue 1606.
R=rsc
CC=golang-dev
http://codereview.appspot.com/4532045
Committer: Russ Cox <rsc@golang.org>

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b