Issue 4442041: GTest Does Not Compile Under Visual Age 10.1 Due To Symbian Workaround

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(163)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4442041: GTest Does Not Compile Under Visual Age 10.1 Due To Symbian Workaround

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Hady

Modified:
11 years, 1 month ago

Reviewers:
wan

CC:
googletestframework_googlegroups.com

Base URL:
http://googletest.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
M	include/gtest/internal/gtest-internal.h	View	2 chunks	+2 lines, -9 lines	1 comment	Download
M	include/gtest/internal/gtest-port.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2

wan

http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-internal.h File include/gtest/internal/gtest-internal.h (right): http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-internal.h#newcode210 include/gtest/internal/gtest-internal.h:210: const operand2_type::value_type* const& str, \ We don't need GTEST_CREF_WORKAROUND_ ...

14 years, 9 months ago (2011年04月15日 18:01:07 UTC) #1

http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-int...
File include/gtest/internal/gtest-internal.h (right):
http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-int...
include/gtest/internal/gtest-internal.h:210: const operand2_type::value_type*
const& str, \
We don't need GTEST_CREF_WORKAROUND_ here?

Hady

I remember needing this here too. To be honest I'm not 100% if it works ...

14 years, 9 months ago (2011年04月16日 09:41:37 UTC) #2

I remember needing this here too. To be honest I'm not 100% if it works without
it. I also figured that it's the same pattern and that it meritted refactoring.
On 2011年04月15日 18:01:07, wan wrote:
>
http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-int...
> File include/gtest/internal/gtest-internal.h (right):
> 
>
http://codereview.appspot.com/4442041/diff/1/include/gtest/internal/gtest-int...
> include/gtest/internal/gtest-internal.h:210: const operand2_type::value_type*
> const& str, \
> We don't need GTEST_CREF_WORKAROUND_ here?