|
|
|
Created:
14 years, 8 months ago by j.s Modified:
14 years, 7 months ago CC:
gdata-python-client-library-contributors_googlegroups.com Visibility:
Public. |
Patch Set 1 #
Total comments: 6
Total messages: 4
|
j.s
|
14 years, 8 months ago (2011年04月23日 01:20:48 UTC) #1 | ||||||||||||||||||||||||||||||||||||||||||
Sorry about taking so long to review. -joe http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... File tests/gdata_tests/spreadsheets/live_client_test.py (right): http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:160: test_worksheet = self.client.add_worksheet( Will this fail if the worksheet already exists? If so then accommodate that condition and continue with the test. http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:194: test_worksheet = self.client.add_worksheet( Same as above comment if the sheet already exists. http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:210: # Update the row. maybe just remember the # of rows and that they decrease, instead of explicitly checking for 1 and 0.
http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... File tests/gdata_tests/spreadsheets/live_client_test.py (right): http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:160: test_worksheet = self.client.add_worksheet( On 2011年05月22日 05:05:05, jcgregorio_google wrote: > Will this fail if the worksheet already exists? If so then accommodate that > condition and continue with the test. No failure, it is possible to have worksheets with the same name. It won't cause a problem since we operate on worksheet ID. http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:194: test_worksheet = self.client.add_worksheet( On 2011年05月22日 05:05:05, jcgregorio_google wrote: > Same as above comment if the sheet already exists. Same as above, no issue. http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l... tests/gdata_tests/spreadsheets/live_client_test.py:210: # Update the row. On 2011年05月22日 05:05:05, jcgregorio_google wrote: > maybe just remember the # of rows and that they decrease, instead of explicitly > checking for 1 and 0. Since we create a new worksheet, I think checking for 0 and 1 would be more accurate.