Issue 4132044: code review 4132044: netchan: graceful handling of closed connection

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(191)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4132044: code review 4132044: netchan: graceful handling of closed connection

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by gmiller

Modified:
14 years, 11 months ago

Reviewers:
r

CC:
r, golang-dev, rog

Visibility:
Public.

netchan: graceful handling of closed connection Currently, when an importer closes the connection, the exporter gives an error message 'netchan export: error decoding client header:EOF'. This change causes the exporter to look for an EOF during the parse of the header, and silences the log message in that case.

Patch Set 1 #

Patch Set 2 : diff -r b1638ab4d480 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b1638ab4d480 https://go.googlecode.com/hg/ #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
M	src/pkg/netchan/export.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4

gmiller

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rog), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 11 months ago (2011年02月06日 22:21:32 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rog),
I'd like you to review this change to
https://go.googlecode.com/hg/

rsc

R=r

14 years, 11 months ago (2011年02月08日 20:26:41 UTC) #2

R=r

LGTM

14 years, 11 months ago (2011年02月08日 20:41:48 UTC) #3

LGTM

*** Submitted as http://code.google.com/p/go/source/detail?r=9f1176d9f901 *** netchan: graceful handling of closed connection Currently, when an importer ...

14 years, 11 months ago (2011年02月08日 20:42:34 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9f1176d9f901 ***
netchan: graceful handling of closed connection
Currently, when an importer closes the connection, the exporter gives an
error message 'netchan export: error decoding client header:EOF'. This
change causes the exporter to look for an EOF during the parse of the
header, and silences the log message in that case.
R=r
CC=golang-dev, rog
http://codereview.appspot.com/4132044
Committer: Rob Pike <r@golang.org>

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b