|
|
Patch Set 1 #
Total comments: 5
Patch Set 2 : new upload #
Total comments: 2
Total messages: 10
|
hoRn
|
14 years, 11 months ago (2011年01月20日 16:38:23 UTC) #1 |
http://codereview.appspot.com/4090041/diff/1/invoice.py File invoice.py (right): http://codereview.appspot.com/4090041/diff/1/invoice.py#newcode201 invoice.py:201: we usually use 4 spaces indent for a block.
error: old chunk mismatch when starting the review. You don't need any base url, when uploading. http://codereview.appspot.com/4090041/diff/1/invoice.py File invoice.py (right): http://codereview.appspot.com/4090041/diff/1/invoice.py#newcode198 invoice.py:198: No need for this comment.
Try to upload ASAP a non-corrupted patch. Others will not necessary find a way to review it. http://codereview.appspot.com/4090041/diff/1/invoice.py File invoice.py (right): http://codereview.appspot.com/4090041/diff/1/invoice.py#newcode196 invoice.py:196: There is trailing spaces http://codereview.appspot.com/4090041/diff/1/invoice.py#newcode201 invoice.py:201: You must link to a copy of analytic_accounts. http://codereview.appspot.com/4090041/diff/1/invoice.py#newcode231 invoice.py:231: Why is it modified?
new upload
On 2011年01月21日 10:07:07, hoRn wrote: > new upload Still broken. I think you should start a new codereview by using upload.py
http://codereview.appspot.com/4090041/diff/21001/invoice.py File invoice.py (right): http://codereview.appspot.com/4090041/diff/21001/invoice.py#newcode199 invoice.py:199: You can not call copy on the BrowseRecord. You must get the Model from the pool. http://codereview.appspot.com/4090041/diff/21001/invoice.py#newcode199 invoice.py:199: Why using the name of 'idx'? Generally it is used for index. You could use 'new_id'.
full ack to all. what can i do?
On 2011年01月24日 23:31:03, hoRn wrote: > full ack to all. what can i do? First of all, best would probably in this case to do a new upload to codereview to have a functional one. Do a clone of your working repos, put there the changes and just upload. Read the documentation of upload.py, it will do the rest for you. python upload.py --help gives you the switches, that are helpful, but initially not required. Usually you can add later your corrections with upload.py -i <number>. If you find the whole process complicated and http://code.google.com/p/rietveld/wiki/CodeReviewHelp is not enough, you could improve http://code.google.com/p/tryton/wiki/HowtoContribute with your experiences.