|
|
|
Created:
14 years, 11 months ago by Paul J Stevens Modified:
14 years, 10 months ago Visibility:
Public. |
Patch Set 1 #
Total comments: 9
Total messages: 3
|
ced
http://codereview.appspot.com/4056045/diff/1/__tryton__.py File __tryton__.py (right): http://codereview.appspot.com/4056045/diff/1/__tryton__.py#newcode7 __tryton__.py:7: 'version': '1.8.1', Why not 1.8.0 ? http://codereview.appspot.com/4056045/diff/1/bank.py File bank.py ...
|
14 years, 11 months ago (2011年01月25日 13:02:10 UTC) #1 |
http://codereview.appspot.com/4056045/diff/1/__tryton__.py File __tryton__.py (right): http://codereview.appspot.com/4056045/diff/1/__tryton__.py#newcode7 __tryton__.py:7: 'version': '1.8.1', Why not 1.8.0 ? http://codereview.appspot.com/4056045/diff/1/bank.py File bank.py (right): http://codereview.appspot.com/4056045/diff/1/bank.py#newcode21 bank.py:21: bic = fields.Char('BIC/SWIFT', select=1, Out of the scope but could be good as there will be migration. By the way, there is a defined length for bic 11 http://en.wikipedia.org/wiki/ISO_9362 http://codereview.appspot.com/4056045/diff/1/bank.py#newcode31 bank.py:31: res[bank.id] = ", ".join(x for x in [bank.name, bank.bank_code, bank.bic] if x) 80 cols http://codereview.appspot.com/4056045/diff/1/bank.py#newcode61 bank.py:61: iban = fields.Char('IBAN', Outside of the scope but it could be good to get IBAN validation with an external lib like for vatnumber. http://codereview.appspot.com/4056045/diff/1/bank.py#newcode77 bank.py:77: # Migration from 1.2: packing renamed into shipment Don't understand the comment ;-) http://codereview.appspot.com/4056045/diff/1/bank.py#newcode122 bank.py:122: BankAccount() Always good to not alter file unnecessary (newline at end of file).
Module is internally already migrated and in testing phase. It will be updated thereafter on intuxication. Nevertheless thanks to all for your input. http://codereview.appspot.com/4056045/diff/1/__tryton__.py File __tryton__.py (right): http://codereview.appspot.com/4056045/diff/1/__tryton__.py#newcode7 __tryton__.py:7: 'version': '1.8.1', I don't think it will get any 1.8, from our side. Our internal procedures require, that a module with even numbers won't get new features, only fixes. See also https://bugs.tryton.org/roundup/issue1828 http://codereview.appspot.com/4056045/diff/1/bank.py File bank.py (right): http://codereview.appspot.com/4056045/diff/1/bank.py#newcode21 bank.py:21: bic = fields.Char('BIC/SWIFT', select=1, On 2011年01月25日 13:02:10, ced wrote: > Out of the scope but could be good as there will be migration. > By the way, there is a defined length for bic 11 > http://en.wikipedia.org/wiki/ISO_9362 Good idea. http://codereview.appspot.com/4056045/diff/1/bank.py#newcode61 bank.py:61: iban = fields.Char('IBAN', On 2011年01月25日 13:02:10, ced wrote: > Outside of the scope but it could be good to get IBAN validation with an > external lib like for vatnumber. On Todo.
On 2011年01月25日 17:13:25, yangoon wrote: > Module is internally already migrated and in testing phase. It will be updated > thereafter on intuxication. Done on http://mercurial.intuxication.org/tryton/party_bank/. I think this codereview can be closed, thx for your input.