Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 40410043: code review 40410043: database/sql: Use all connections in pool

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by johto
Modified:
12 years ago
Reviewers:
bradfitz
CC:
golang-codereviews, gobot, bradfitz
Visibility:
Public.
database/sql: Use all connections in pool The last connection in the pool was not being handed out correctly.

Patch Set 1 #

Patch Set 2 : diff -r 812d1128f288 https://code.google.com/p/go #

Patch Set 3 : diff -r 812d1128f288 https://code.google.com/p/go #

Created: 12 years, 1 month ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M src/pkg/database/sql/sql.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 1 chunk +23 lines, -0 lines 0 comments Download
Total messages: 5
|
johto
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013年12月10日 19:27:54 UTC) #1
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go 
Sign in to reply to this message.
gobot
R=bradfitz@golang.org (assigned by r@golang.org)
12 years ago (2013年12月19日 21:24:19 UTC) #2
R=bradfitz@golang.org (assigned by r@golang.org)
Sign in to reply to this message.
gobot
Replacing golang-dev with golang-codereviews.
12 years ago (2013年12月20日 16:26:20 UTC) #3
Replacing golang-dev with golang-codereviews.
Sign in to reply to this message.
bradfitz
LGTM
12 years ago (2013年12月26日 19:27:12 UTC) #4
LGTM
Sign in to reply to this message.
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=8a7ac002f840 *** database/sql: Use all connections in pool The last connection in ...
12 years ago (2013年12月26日 19:27:27 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=8a7ac002f840 ***
database/sql: Use all connections in pool
The last connection in the pool was not being handed out correctly.
R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/40410043
Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /