Issue 3804045: Use ProtoRPC compatible URLS for mapreduce commands.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(264)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3804045: Use ProtoRPC compatible URLS for mapreduce commands.

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by RafeKap

Modified:
11 years, 1 month ago

Reviewers:
Fred Wulff

Base URL:
http://appengine-mapreduce.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Maybe this will have a diff. #

Created: 15 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -92 lines)			Patch
M	java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java	View	1	38 chunks	+113 lines, -90 lines	0 comments	Download
M	java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4

RafeKap

15 years ago (2011年01月05日 23:56:00 UTC) #1

Fred Wulff

Hmm...I'm not seeing any diffs. On Wed, Jan 5, 2011 at 3:56 PM, <rafek@google.com> wrote: ...

15 years ago (2011年01月06日 00:18:52 UTC) #2

Hmm...I'm not seeing any diffs.
On Wed, Jan 5, 2011 at 3:56 PM, <rafek@google.com> wrote:
> Reviewers: Fred Wulff,
>
>
>
> Please review this at http://codereview.appspot.com/3804045/
>
> Affected files:
> M java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
> M
> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
>
>
> Index:
> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
> ===================================================================
> Index: java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
> ===================================================================
>
>
>

RafeKap

Was using alternate diff program that confused SVN. Check now please. On Wed, Jan 5, ...

15 years ago (2011年01月06日 00:53:10 UTC) #3

 Was using alternate diff program that confused SVN. Check now please.
On Wed, Jan 5, 2011 at 4:18 PM, Fred Wulff <frew@google.com> wrote:
> Hmm...I'm not seeing any diffs.
>
> On Wed, Jan 5, 2011 at 3:56 PM, <rafek@google.com> wrote:
>>
>> Reviewers: Fred Wulff,
>>
>>
>>
>> Please review this at http://codereview.appspot.com/3804045/
>>
>> Affected files:
>> M   java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
>> M
>> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
>>
>>
>> Index:
>> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
>> ===================================================================
>> Index: java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
>> ===================================================================
>>
>>
>
>

Fred Wulff

LGTM Gave you commit access to the repo on your @google.com account. Let me know ...

15 years ago (2011年01月06日 01:15:40 UTC) #4

LGTM
Gave you commit access to the repo on your @google.com account. Let me know
if you'd prefer me to merge it in for you.
On Wed, Jan 5, 2011 at 4:53 PM, Rafe Kaplan <rafek@google.com> wrote:
> Was using alternate diff program that confused SVN. Check now please.
>
> On Wed, Jan 5, 2011 at 4:18 PM, Fred Wulff <frew@google.com> wrote:
> > Hmm...I'm not seeing any diffs.
> >
> > On Wed, Jan 5, 2011 at 3:56 PM, <rafek@google.com> wrote:
> >>
> >> Reviewers: Fred Wulff,
> >>
> >>
> >>
> >> Please review this at http://codereview.appspot.com/3804045/
> >>
> >> Affected files:
> >> M
> java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
> >> M
> >> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
> >>
> >>
> >> Index:
> >> java/test/com/google/appengine/tools/mapreduce/MapReduceServletTest.java
> >> ===================================================================
> >> Index:
> java/src/com/google/appengine/tools/mapreduce/MapReduceServlet.java
> >> ===================================================================
> >>
> >>
> >
> >
>

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b