|
|
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.g... src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong It's not wrong any more :)
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.g... src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong On 2013年12月10日 23:45:17, dfc wrote: > It's not wrong any more :) Done.
LGTM.
Replacing golang-dev with golang-codereviews.
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
R=jsing@google.com (assigned by aram@mgk.ro)
LGTM https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g... src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights reserved. Copyright years are not updated - please revert this, given that the file is predominantly a copy.
> On 8 Jan 2014, at 21:38, jsing@google.com wrote: > > LGTM > > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go > File src/pkg/os/stat_solaris.go (right): > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g... > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All > rights reserved. > Copyright years are not updated - please revert this, given that the > file is predominantly a copy. Id like to disagree, this is a new file, even if 99% of it is a copy from someplace else. > > https://codereview.appspot.com/36020043/
On 2014年01月08日 11:07:09, dfc wrote: > > > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote: > > > > LGTM > > > > > > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go > > File src/pkg/os/stat_solaris.go (right): > > > > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g... > > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All > > rights reserved. > > Copyright years are not updated - please revert this, given that the > > file is predominantly a copy. > > Id like to disagree, this is a new file, even if 99% of it is a copy from > someplace else. It may be a new file, however it is a derivative work and as I understand it, the original copyright year applies.
Sure. But I can cite many examples in the current code base that can support *both* of our positions. > On 8 Jan 2014, at 22:30, jsing@google.com wrote: > >> On 2014年01月08日 11:07:09, dfc wrote: >> >> > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote: >> > >> > LGTM >> > >> > >> > > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go >> > File src/pkg/os/stat_solaris.go (right): >> > >> > > > https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g... >> > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All >> > rights reserved. >> > Copyright years are not updated - please revert this, given that the >> > file is predominantly a copy. > >> Id like to disagree, this is a new file, even if 99% of it is a copy > from >> someplace else. > > It may be a new file, however it is a derivative work and as I > understand it, the original copyright year applies. > > https://codereview.appspot.com/36020043/ > > -- > You received this message because you are subscribed to the Google Groups "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out.
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g... src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights reserved. On 2014年01月08日 10:38:35, jsing wrote: > Copyright years are not updated - please revert this, given that the file is > predominantly a copy. Done.
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com, gobot@golang.org, jsing@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
*** Submitted as https://code.google.com/p/go/source/detail?r=99a1e180eda3 *** os, os/exec, os/user: add support for GOOS=solaris R=golang-codereviews, dave, minux.ma, gobot, jsing CC=golang-codereviews https://codereview.appspot.com/36020043 Committer: Joel Sing <jsing@google.com>