|
|
|
Fixes two issues that broke manual provider usage for me, needlessly requiring of dns names instead of ips, and typo that broke non-state server api connections.
https://code.launchpad.net/~hazmat/juju-core/manual-provider-fixes/+merge/196718
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 6
Patch Set 2 : - #
Total messages: 5
|
hazmat
Please take a look.
|
12 years, 1 month ago (2013年11月26日 14:21:52 UTC) #1 | |||||||||||||||||||||||||||||||
Please take a look.
LGTM but we should probably have a test in environs/manual. https://codereview.appspot.com/32890043/diff/1/environs/manual/provisioner.go File environs/manual/provisioner.go (right): https://codereview.appspot.com/32890043/diff/1/environs/manual/provisioner.go... environs/manual/provisioner.go:185: Addrs: configParameters.APIAddrs, this seems like it should have an associated test. https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go File provider/null/instance.go (right): https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go#newc... provider/null/instance.go:40: // do a reverse lookup. this comment is no longer appropriate. https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go#newc... provider/null/instance.go:42: return host, nil s/host/inst.host/
thanks for the review. https://codereview.appspot.com/32890043/diff/1/environs/manual/provisioner.go File environs/manual/provisioner.go (right): https://codereview.appspot.com/32890043/diff/1/environs/manual/provisioner.go... environs/manual/provisioner.go:185: Addrs: configParameters.APIAddrs, On 2013年11月26日 14:29:13, rog wrote: > this seems like it should have an associated test. i took a look at this but it doesn't slot into the existing tests very well. i'll ask axw to address in a followup, but for now i'd like to address the broken provider for what is a clear logical typo. https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go File provider/null/instance.go (right): https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go#newc... provider/null/instance.go:40: // do a reverse lookup. On 2013年11月26日 14:29:13, rog wrote: > this comment is no longer appropriate. done. https://codereview.appspot.com/32890043/diff/1/provider/null/instance.go#newc... provider/null/instance.go:42: return host, nil On 2013年11月26日 14:29:13, rog wrote: > s/host/inst.host/ done.