Issue 3268042: code review 3268042: sync: small naming fix for armv5

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(27)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3268042: code review 3268042: sync: small naming fix for armv5

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by dpx

Modified:
3 years, 4 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

sync: small naming fix for armv5

Patch Set 1 #

Patch Set 2 : code review 3268042: sync: small naming fix for armv5 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
M	src/pkg/sync/asm_arm5.s	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

dpx

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010年11月29日 22:45:29 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com),
I'd like you to review this change.

rsc

LGTM

15 years, 1 month ago (2010年12月07日 17:04:49 UTC) #2

LGTM

rsc

*** Submitted as 483f1bd9ba38 *** sync: small naming fix for armv5 R=rsc CC=golang-dev http://codereview.appspot.com/3268042 Committer: ...

15 years, 1 month ago (2010年12月07日 17:05:07 UTC) #3

*** Submitted as 483f1bd9ba38 ***
sync: small naming fix for armv5
R=rsc
CC=golang-dev
http://codereview.appspot.com/3268042
Committer: Russ Cox <rsc@golang.org>