|
|
Patch Set 1 #
Total comments: 1
Patch Set 2 : add an exception about short local variable names #Patch Set 3 : addresses Chris' comments. #Total messages: 1
|
chandlerc
http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html File docs/CodingStandards.html (right): http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html#newcode801 docs/CodingStandards.html:801: camel case (e.g. <tt>TextFileReader</tt> and <tt>isLValue</tt>). I would really ...
|
15 years, 1 month ago (2010年11月23日 05:27:58 UTC) #1 |
http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html File docs/CodingStandards.html (right): http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html#newcod... docs/CodingStandards.html:801: camel case (e.g. <tt>TextFileReader</tt> and <tt>isLValue</tt>). I would really prefer some stylistic difference between variables and types/functions. This is mostly a problem (for me) with local variables, where having some signifier of the locality helps me in reading it. The most common style I have worked with is to use under_score_separators for variables. Personally, I would advocate for sharing this style with member variables as well, but those aren't as important to me when reading code.