Issue 3127041: cosmetic changes to LLVM coding standards; also groups sections for iostream & raw_ostream together

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(61)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3127041: cosmetic changes to LLVM coding standards; also groups sections for iostream & raw_ostream together

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by wan

Modified:
11 years, 1 month ago

Reviewers:
bigcheesegs

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/docs/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -49 lines)			Patch
M	CodingStandards.html	View	23 chunks	+48 lines, -49 lines	1 comment	Download

Total messages: 2

Bigcheesegs

Looks good to me. One small comment below. http://codereview.appspot.com/3127041/diff/1/CodingStandards.html File CodingStandards.html (right): http://codereview.appspot.com/3127041/diff/1/CodingStandards.html#newcode721 CodingStandards.html:721: <p>It ...

15 years, 1 month ago (2010年11月16日 02:10:56 UTC) #1

Looks good to me. One small comment below.
http://codereview.appspot.com/3127041/diff/1/CodingStandards.html
File CodingStandards.html (right):
http://codereview.appspot.com/3127041/diff/1/CodingStandards.html#newcode721
CodingStandards.html:721: <p>It is very common to write small loops that just
compute a Boolean
Not sure I agree with this change. Why should it be capitalized?

wan

http://en.m.wikipedia.org/wiki/Boolean Because that's the proper way to write it? "Boolean" is derived from the special ...

15 years, 1 month ago (2010年11月16日 02:34:27 UTC) #2

http://en.m.wikipedia.org/wiki/Boolean
Because that's the proper way to write it? "Boolean" is derived from the
special noun "Boole", so 'B' should always be in uppercase.
I don't mean to be a grammar lawyer, but while I was at it...
On Nov 15, 2010 6:11 PM, <Bigcheesegs@gmail.com> wrote: