Issue 2956: Performance Enhancement for MockHandler : Search matchers once instead of twice

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(76)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 2956: Performance Enhancement for MockHandler : Search matchers once instead of twice

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 4 months ago by iczechowski

Modified:
2 years, 2 months ago

Reviewers:
szczepiq

Base URL:
http://mockito.googlecode.com/svn/trunk

Visibility:
Public.

MockHandler currently calls these 2 methods in quick succession when providing the stubbed result for an invocation: mockitoStubber.hasResultFor(invocation) mockitoStubber.getResultFor(invocation) Unfortunately this involves duplication of work, because both methods call findMatch(invocation), which in turn will search *all* of the stubbed invocations against this mock instance. The search is performed twice, when it only needs to be performed once. See: http://code.google.com/p/mockito/issues/detail?id=19

Patch Set 1 #

Created: 17 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
src/org/mockito/internal/MockHandler.java	View	2 chunks	+5 lines, -2 lines	0 comments	Download
src/org/mockito/internal/stubbing/MockitoStubber.java	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 1

iczechowski

17 years, 4 months ago (2008年08月18日 15:57:26 UTC) #1