Issue 26370044: Fix delimiter in dependencies.tsv

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(469)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 26370044: Fix delimiter in dependencies.tsv

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by curtis

Modified:
12 years, 1 month ago

Reviewers:
gz , mp+195236, rog

Visibility:
Public.

Fix delimiter in dependencies.tsv Developers and CI cannot update the source to the correct deps because spaces are used on the goyaml line. The delimiter must be tabs. https://code.launchpad.net/~sinzui/juju-core/fix-deps/+merge/195236 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dependencies.tsv	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

curtis

Please take a look.

12 years, 1 month ago (2013年11月14日 15:14:54 UTC) #1

Please take a look.

LGTM.

12 years, 1 month ago (2013年11月14日 15:39:10 UTC) #2

LGTM.

rog

On 2013年11月14日 15:39:10, gz wrote: > LGTM. This has happened before. I will fix godeps ...

12 years, 1 month ago (2013年11月14日 15:44:50 UTC) #3

On 2013年11月14日 15:39:10, gz wrote:
> LGTM.
This has happened before. I will fix godeps so that
it complains if it finds spaces next to tabs.
FWIW, we don't need to generate the godeps lines
manually - the output from godeps itself should
work, and mean that we don't have the possibility
of problems like this.
Also the 'bot should complain if the deps can't
be found, which would stop this happening too.