Issue 2582: Makes gtest's error messages parsable by Visual Studio when compiled by MSVC. By balazs.dan.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(262)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 2582: Makes gtest's error messages parsable by Visual Studio when compiled by MSVC. By balazs.dan.

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 6 months ago by Zhanyong

Modified:
11 years, 1 month ago

Reviewers:
wan, balazs.dan

CC:
googletestframework_googlegroups.com, balazs.dan_gmail.com

Base URL:
http://googletest.googlecode.com/svn/trunk/src/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : second attempt #

Patch Set 3 : Third attempt #

Patch Set 4 : Makes sure the tests pass. #

Created: 17 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -114 lines)
CONTRIBUTORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/gtest.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
test/gtest_output_test.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
test/gtest_output_test_golden_win.txt	View	18 chunks	+55 lines, -110 lines	0 comments	Download

Total messages: 1

Zhanyong

http://codereview.appspot.com/2582/diff/1/2 File gtest.cc (right): http://codereview.appspot.com/2582/diff/1/2#newcode2155 Line 2155: return "Failure"; I would change this to "Failure\n" ...

17 years, 6 months ago (2008年07月16日 23:24:27 UTC) #1

http://codereview.appspot.com/2582/diff/1/2
File gtest.cc (right):
http://codereview.appspot.com/2582/diff/1/2#newcode2155
Line 2155: return "Failure";
I would change this to "Failure\n" here.
http://codereview.appspot.com/2582/diff/1/2#newcode2178
Line 2178: printf(": %s\n",
TestPartResultTypeToString(test_part_result.type()));
Then this branch (and the #ifdef) can be removed.