Issue 2387042: code review 2387042: emit load command of correct size for LC_RPATH when bui...

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(158)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 2387042: code review 2387042: emit load command of correct size for LC_RPATH when bui...

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by mcgoo

Modified:
2 years, 2 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

emit load command of correct size for LC_RPATH when building mach-o 64 binary Fixes issue 1177.

Patch Set 1 #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
M	src/cmd/ld/macho.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3

mcgoo

Hello golang-dev@googlegroups.com, I'd like you to review this change.

15 years, 3 months ago (2010年10月08日 17:40:00 UTC) #1

Hello golang-dev@googlegroups.com,
I'd like you to review this change.

rsc

LGTM Thanks again!

15 years, 3 months ago (2010年10月11日 15:29:58 UTC) #2

LGTM
Thanks again!

rsc

*** Submitted as 5ca6f6c1b8e7 *** 6l: fix Mach-O LC_RPATH Fixes issue 1177. R=golang-dev, rsc CC=golang-dev ...

15 years, 3 months ago (2010年10月11日 18:39:43 UTC) #3

*** Submitted as 5ca6f6c1b8e7 ***
6l: fix Mach-O LC_RPATH
Fixes issue 1177.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/2387042
Committer: Russ Cox <rsc@golang.org>