Issue 2321042: Provide user-friendly message when an exception is raised trough JSONRPC

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(192)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 2321042: Provide user-friendly message when an exception is raised trough JSONRPC

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by bch

Modified:
15 years, 1 month ago

Reviewers:
ced

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Send exception.args for error_message #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
M	trytond/protocols/jsonrpc.py	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2

ced

http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py File trytond/protocols/jsonrpc.py (right): http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py#newcode111 trytond/protocols/jsonrpc.py:111: try: I think it should not be try/except http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py#newcode112 ...

15 years, 3 months ago (2010年10月04日 16:38:40 UTC) #1

http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py
File trytond/protocols/jsonrpc.py (right):
http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py#new...
trytond/protocols/jsonrpc.py:111: try:
I think it should not be try/except
http://codereview.appspot.com/2321042/diff/1/trytond/protocols/jsonrpc.py#new...
trytond/protocols/jsonrpc.py:112: response['error_message'] =
sys.exc_info()[1][1]
Why not (like in netrpc):
response['error_message'] = exception.args