|
|
|
fix quoted strings in Marshal
Patch Set 1 #
Total comments: 1
Patch Set 2 : code review 217047: fix quoted strings in Marshal #Patch Set 3 : code review 217047: fix quoted strings in Marshal #
Total messages: 7
|
rsc
looks good. please change the comment and also run "hg change 217047" and edit the ...
|
15 years, 10 months ago (2010年02月19日 16:37:35 UTC) #1 | ||||||||||||||||||||||||
looks good. please change the comment and also run "hg change 217047" and edit the CL description to say json: fix quoted strings in Marshal then run hg mail 217047 to reupload and let us know that it's ready to look at again. thanks. http://codereview.appspot.com/217047/diff/1/2 File src/pkg/json/struct.go (right): http://codereview.appspot.com/217047/diff/1/2#newcode441 src/pkg/json/struct.go:441: // Marshal converts an arbitrary value to the JSON syntax and writes it to w. // Marshal writes the JSON encoding of val to w. // // Due to limitations in JSON, val cannot include cyclic data // structures, channels, functions, or maps. the comment about human-readable is unnecessary commentary.
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
LGTM thanks
Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright
Completed. > Please complete a CLA as described at > http://golang.org/doc/contribute.html#copyright
*** Submitted as http://code.google.com/p/go/source/detail?r=011400aed900 *** json: fix quoted strings in Marshal R=rsc CC=golang-dev http://codereview.appspot.com/217047 Committer: Russ Cox <rsc@golang.org>