Issue 1892053: remove invalid XML chars from multi-line diff AJAX response

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(24)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1892053: remove invalid XML chars from multi-line diff AJAX response

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by Jake McGuire

Modified:
15 years, 4 months ago

Reviewers:
Andi Albrecht

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Some people put ^L in their source code files as a means of separating functions or whatever. ^L is not a valid XML character, so when we try to send it back in response to the AJAX request to show hidden lines in a side-by-side diff we get an ExpatError. There is no common function to remove illegal XML characters, so I created one and called it in the appropriate place.

Patch Set 1 #

Patch Set 2 : add a comment explaining what's going on and correct number of newlines #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	codereview/views.py	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Total messages: 3

Andi Albrecht

Hey Jake, sorry, I missed that. Is that ready for review? Andi

15 years, 4 months ago (2010年08月22日 10:20:47 UTC) #1

Hey Jake,
sorry, I missed that. Is that ready for review?
Andi

Jake McGuire

Yup. It's ready for review, and has been running on the Chromium Rietveld instance for ...

15 years, 4 months ago (2010年08月23日 04:12:58 UTC) #2

Yup. It's ready for review, and has been running on the Chromium Rietveld
instance for a while now.

Andi Albrecht

LGTM

15 years, 4 months ago (2010年08月24日 09:01:45 UTC) #3

LGTM