|
|
|
Created:
15 years, 12 months ago by nickcarter Modified:
15 years, 12 months ago Reviewers:
kenton CC:
chromium-reviews_googlegroups.com, protobuf_googlegroups.com Base URL:
http://protobuf.googlecode.com/svn/trunk/ Visibility:
Public. |
Fix two issues with protobufs on Windows:
[1] subprocess.cc wouldn't compile if UNICODE was defined.
Explicitly call the ASCII variant.
This is issue 157:
http://code.google.com/p/protobuf/issues/detail?id=157
[2] Move the windows.h GetMessage name-collision workaround
into the common header, so that the workaround is visible
to both extension_set.h and message.h.
Both of those headers declare methods named GetMessage.
This is issue 156:
http://code.google.com/p/protobuf/issues/detail?id=156
Patch Set 1 #Patch Set 2 : '' #
Total messages: 2
|
nickcarter
Hi Kenton, This patch fixes the two issues I reported. Nick
|
15 years, 12 months ago (2010年01月14日 21:53:19 UTC) #1 | ||||||||||||||||||||||||||||||
Hi Kenton, This patch fixes the two issues I reported. Nick
Ahhh, someone who knows the process. Looks great! Committed as rev 305.