Issue 186182: Rewrite strtod parser; fixes bugs 5 and 7 of issue 7632

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(58)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 186182: Rewrite strtod parser; fixes bugs 5 and 7 of issue 7632

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by dickinsm

Modified:
11 years, 4 months ago

Reviewers:

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

In this patch: 1. Despagghetification of _Py_dg_strtod parser and exit points. 2. Removal of unused dsign field from BCinfo struct; make it a local variable instead. 3. Simplify bigcomp comparison loop. 4. Don't set ERANGE on underflow.

Patch Set 1 #

Patch Set 2 : 2nd draft of parser rewrite; updated against current svn #

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -182 lines)			Patch
M	Python/dtoa.c	View	1	19 chunks	+162 lines, -182 lines	0 comments	Download

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b