Issue 1847046: Add support for TTC font files in SkFontHost_Freetype....

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(147)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1847046: Add support for TTC font files in SkFontHost_Freetype....

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by jshin

Modified:
15 years, 5 months ago

Reviewers:
agl

CC:
skia-review_googlegroups.com, evan

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Add support for TTC font files in SkFontHost_Freetype. This is a companion change to a Chrome CL ( http://codereview.chromium.org/2870073/show ) BUG=http://crbug.com/50389 TEST=See the Chromium CL mentioned above.

Patch Set 1 #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
M	src/ports/SkFontHost_FreeType.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 5

jshin

15 years, 5 months ago (2010年07月28日 07:55:29 UTC) #1

jshin

15 years, 5 months ago (2010年07月28日 18:25:42 UTC) #2

agl

LGTM

15 years, 5 months ago (2010年07月28日 18:49:42 UTC) #3

LGTM

jshin

Thank you for the review. Can you check this in? The chrome-side change was just ...

15 years, 5 months ago (2010年08月06日 18:05:57 UTC) #4

Thank you for the review. Can you check this in? The chrome-side change was just
checked in (implementing GetFileName only to retrieve the face index). Then,
I'll update skia revision on Chrome-side (after running webkit tests).

agl

On Fri, Aug 6, 2010 at 2:05 PM, <jshin@chromium.org> wrote: > Thank you for the ...

15 years, 5 months ago (2010年08月06日 18:10:31 UTC) #5

On Fri, Aug 6, 2010 at 2:05 PM, <jshin@chromium.org> wrote:
> Thank you for the review. Can you check this in? The chrome-side change
> was just checked in (implementing GetFileName only to retrieve the face
> index). Then, I'll update skia revision on Chrome-side (after running
> webkit tests).
Landed as r593.
AGL

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b