Issue 183096: Add flag to enable bitmap strikes.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(146)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 183096: Add flag to enable bitmap strikes.

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by agl

Modified:
16 years ago

Reviewers:
reed

Visibility:
Public.

Add flag to enable bitmap strikes.

Patch Set 1 #

Created: 16 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
M	include/core/SkPaint.h	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	include/core/SkScalerContext.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 3

agl

16 years ago (2009年12月31日 00:19:31 UTC) #1

reed

What do you mean by kBitmapStrikes? Embedded bitmaps inside the font? If so, how about ...

16 years ago (2009年12月31日 01:17:42 UTC) #2

What do you mean by kBitmapStrikes? Embedded bitmaps inside the font? If so, how
about calling it EmbeddedBitmapText, to close match the meaning (to me anyway),
and the pattern of adding Text after the name for flags related to text/fonts.
It looks like you have an unrelated change in freetype, adding the LCD formats
to an if-statement, which seems fine.
On 2009年12月31日 00:19:31, agl wrote:
>

agl

On 2009年12月31日 01:17:42, reed wrote: > What do you mean by kBitmapStrikes? Embedded bitmaps inside ...

16 years ago (2010年01月04日 18:25:46 UTC) #3

On 2009年12月31日 01:17:42, reed wrote:
> What do you mean by kBitmapStrikes? Embedded bitmaps inside the font? If so,
how
> about calling it EmbeddedBitmapText, to close match the meaning (to me
anyway),
> and the pattern of adding Text after the name for flags related to text/fonts.
Renamed.
> It looks like you have an unrelated change in freetype, adding the LCD formats
> to an if-statement, which seems fine.
It's actually related. Once you enable bitmap strikes, you need to add these LCD
formats to the if statement otherwise we can't convert the bitmaps to masks and
we hit an assert.
Thanks for the review. Landing now.
AGL