Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(230)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 182540043: [dev.cc] code review 182540043: runtime: add tracing of runtime events

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dvyukov
Modified:
11 years ago
Reviewers:
CC:
rsc, golang-codereviews
Visibility:
Public.
runtime: add tracing of runtime events Add actual tracing of interesting runtime events. Part of a larger tracing functionality: https://docs.google.com/document/u/1/d/1FP5apqzBgr7ahCCgFO-yoVhk4YZrNIDNf9RybngBc14/pub Full change: https://codereview.appspot.com/146920043

Patch Set 1 #

Patch Set 2 : diff -r 81884b89bd88b9d2e4cb7d1219ccaf95b9211939 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 81884b89bd88b9d2e4cb7d1219ccaf95b9211939 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 81884b89bd88b9d2e4cb7d1219ccaf95b9211939 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 1 month ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -40 lines) Patch
M src/runtime/chan.go View 1 6 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/malloc.go View 1 3 chunks +10 lines, -1 line 0 comments Download
M src/runtime/malloc1.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/mgc.go View 1 6 chunks +26 lines, -0 lines 0 comments Download
M src/runtime/mgc0.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/mheap.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/runtime/netpoll.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/proc.go View 1 5 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/proc1.go View 1 2 33 chunks +176 lines, -18 lines 0 comments Download
M src/runtime/runtime2.go View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/runtime/select.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/sema.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/stack1.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/time.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
Total messages: 2
|
dvyukov
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.cc branch ...
11 years, 1 month ago (2014年12月05日 18:44:03 UTC) #1
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
I'd like you to review this change to the dev.cc branch of
https://dvyukov%40google.com@code.google.com/p/go/ 
Sign in to reply to this message.
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
11 years ago (2014年12月19日 05:17:14 UTC) #2
R=close
To the author of this CL:
The Go project has moved to Gerrit Code Review.
If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.
If there has been discussion on this CL, please give a link to it
(golang.org/cl/182540043 is best) in the description in your
new CL.
Thanks very much.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /