|
|
|
Created:
11 years, 1 month ago by tmatsuo(Google) Modified:
11 years ago Reviewers:
gmlewis1 CC:
gmlewis1, bradfitz, golang-codereviews Visibility:
Public. |
pubsub: Updated the example to use the new batch interfaces.
Patch Set 1 #Patch Set 2 : diff -r 6ddfebb10ece https://code.google.com/p/google-api-go-client #Patch Set 3 : diff -r 6ddfebb10ece https://code.google.com/p/google-api-go-client #Patch Set 4 : diff -r 6ddfebb10ece https://code.google.com/p/google-api-go-client #
Total comments: 8
Patch Set 5 : diff -r 6ddfebb10ece https://code.google.com/p/google-api-go-client #
Total messages: 8
|
tmatsuo(Google)
Hello gmlewis@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/google-api-go-client
|
11 years, 1 month ago (2014年11月25日 14:29:32 UTC) #1 | ||||||||||||||
Hello gmlewis@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/google-api-go-client
Sorry for the delay! I have a few minor comments below. Otherwise, LGTM. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go File examples/pubsub.go (right): https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:265: log.Printf("Published a message to the topic with message_id: %s.\n", This could probably be all on the same line. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:281: continue This seems like it could be an infinite loop. Do you want "break" instead of "continue"? https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:286: data, err := base64.StdEncoding.DecodeString( This should probably be on a single line. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:289: log.Fatal("Got an error while decoding the message: %v", err) log.Fatalf
Thanks Glenn, PTAL https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go File examples/pubsub.go (right): https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:265: log.Printf("Published a message to the topic with message_id: %s.\n", On 2014年12月01日 22:19:32, gmlewis1 wrote: > This could probably be all on the same line. Done. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:281: continue On 2014年12月01日 22:19:32, gmlewis1 wrote: > This seems like it could be an infinite loop. Do you want "break" instead of > "continue"? Done. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:286: data, err := base64.StdEncoding.DecodeString( On 2014年12月01日 22:19:32, gmlewis1 wrote: > This should probably be on a single line. Done. https://codereview.appspot.com/179430043/diff/60001/examples/pubsub.go#newcod... examples/pubsub.go:289: log.Fatal("Got an error while decoding the message: %v", err) On 2014年12月01日 22:19:32, gmlewis1 wrote: > log.Fatalf Done.
LGTM. Please add bradfitz@golang.org for final review and LGTM before submitting.
On 2014年12月01日 23:48:49, gmlewis1 wrote: > LGTM. Please add mailto:bradfitz@golang.org for final review and LGTM before > submitting. Sure. Brad, can you take a look?
On 2014年12月01日 23:51:58, tmatsuo(Google) wrote: > On 2014年12月01日 23:48:49, gmlewis1 wrote: > > LGTM. Please add mailto:bradfitz@golang.org for final review and LGTM before > > submitting. > > Sure. > > Brad, can you take a look? I think I should move this to gerrit due to the migration, and I'm going to do that shortly.
On 2014年12月11日 16:12:11, tmatsuo(Google) wrote: > On 2014年12月01日 23:51:58, tmatsuo(Google) wrote: > > On 2014年12月01日 23:48:49, gmlewis1 wrote: > > > LGTM. Please add mailto:bradfitz@golang.org for final review and LGTM > before > > > submitting. > > > > Sure. > > > > Brad, can you take a look? > > I think I should move this to gerrit due to the migration, and I'm going to do > that shortly. Moved to: https://code-review.googlesource.com/#/c/1510/
R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/179430043 is best) in the description in your new CL. Thanks very much.