Issue 176049: Fix the makefile for linux

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(13)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 176049: Fix the makefile for linux

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by cykoo1

Modified:
16 years, 1 month ago

Reviewers:
Jeffrey Yasskin

CC:
google-concurrency-library_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

cykoo1

16 years, 1 month ago (2009年12月11日 21:08:52 UTC) #1

Jeffrey Yasskin

LGTM On Fri, Dec 11, 2009 at 1:08 PM, <cykoo1@gmail.com> wrote: > Reviewers: Jeffrey Yasskin, ...

16 years, 1 month ago (2009年12月11日 21:12:45 UTC) #2

LGTM
On Fri, Dec 11, 2009 at 1:08 PM, <cykoo1@gmail.com> wrote:
> Reviewers: Jeffrey Yasskin,
>
>
>
> Please review this at http://codereview.appspot.com/176049
>
> Affected files:
> M Makefile
>
>
> Index: Makefile
> ===================================================================
> --- a/Makefile
> +++ b/Makefile
> @@ -56,7 +56,7 @@
> TEST_OBJS := testing/thread_test.o testing/lock_test.o testing/race_test.o
> \
>        testing/concurrent_priority_queue_test.o
> AllTests: CppFlags += -Iinclude $(GTEST_I) $(GMOCK_I)
> -AllTests: std_thread.a $(GMOCK_MAIN_A) $(TEST_OBJS)
> +AllTests: $(TEST_OBJS) std_thread.a $(GMOCK_MAIN_A)
>    $(CXX) -o $@ $(LdFlags) $^ $(LOADLIBES) $(LdLibs)
>
>
>
>
>
-- 
Namasté,
Jeffrey Yasskin
http://jeffrey.yasskin.info/