Issue 1706045: Fix gcc4.2/clang compile error

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(439)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1706045: Fix gcc4.2/clang compile error

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by thakis

Modified:
15 years, 6 months ago

Reviewers:
reed, agl

Base URL:
http://skia.googlecode.com/svn/trunk/src/

Visibility:
Public.

Fix gcc4.2/clang compile error Having an empty clobbered register list is ok in gcc 4.0, but an error in gcc 4.2 and clang.

Patch Set 1 #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
M	opts/opts_check_SSE2.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3

thakis

15 years, 6 months ago (2010年06月21日 04:18:03 UTC) #1

agl

On Mon, Jun 21, 2010 at 12:18 AM, <thakis@chromium.org> wrote: > Reviewers: reed, agl, > ...

15 years, 6 months ago (2010年06月22日 17:09:20 UTC) #2

On Mon, Jun 21, 2010 at 12:18 AM, <thakis@chromium.org> wrote:
> Reviewers: reed, agl,
>
> Description:
> Fix gcc4.2/clang compile error
>
> Having an empty clobbered register list is ok in gcc 4.0, but an error
> in gcc 4.2 and clang.
LGTM. Due to traveling, it could be a week until I can land this.
AGL

reed

I landed it today. On Tue, Jun 22, 2010 at 1:09 PM, Adam Langley <agl@chromium.org> ...

15 years, 6 months ago (2010年06月24日 21:04:42 UTC) #3

I landed it today.
On Tue, Jun 22, 2010 at 1:09 PM, Adam Langley <agl@chromium.org> wrote:
> On Mon, Jun 21, 2010 at 12:18 AM,  <thakis@chromium.org> wrote:
>> Reviewers: reed, agl,
>>
>> Description:
>> Fix gcc4.2/clang compile error
>>
>> Having an empty clobbered register list is ok in gcc 4.0, but an error
>> in gcc 4.2 and clang.
>
> LGTM. Due to traveling, it could be a week until I can land this.
>
>
> AGL
>