|
|
|
To lighten your support burden.
Patch Set 1 #
Total comments: 2
Patch Set 2 : '' #Total messages: 9
|
thakis
|
15 years, 6 months ago (2010年06月24日 01:08:09 UTC) #1 |
LGTM http://codereview.appspot.com/1671043/diff/1/2 File git-cl (right): http://codereview.appspot.com/1671043/diff/1/2#newcode606 git-cl:606: if RunGit(['diff-index', 'HEAD']): this one too i think
Do I check this in somewhere, or do you do the rest? http://codereview.appspot.com/1671043/diff/1/2 File git-cl (right): http://codereview.appspot.com/1671043/diff/1/2#newcode606 git-cl:606: if RunGit(['diff-index', 'HEAD']): On 2010年06月24日 01:11:11, evan wrote: > this one too i think Done.
m-a knows how to check in
If you have commit access to chromium os, git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git git fetch main (then hack your .git/config to switch the upstream branch to main, maybe Evan knows the actual git command) git cl push otherwise I can commit it but I prefer proper commit attribution when possible.
I don't have commit access. Use git Cl dcommit -c thakis :-p On Jun 24, 2010 7:04 PM, <maruel@chromium.org> wrote: > If you have commit access to chromium os, > > git remote add main ssh://git@gitrw.chromium.org:9222/git-cl.git > git fetch main > (then hack your .git/config to switch the upstream branch to main, maybe > Evan knows the actual git command) > git cl push > > otherwise I can commit it but I prefer proper commit attribution when > possible. > > http://codereview.appspot.com/1671043/show
M-A, say, did you still not land this?
On 2010年07月16日 18:48:49, thakis wrote: > M-A, say, did you still not land this? I had forgot, done.
On 2010年07月18日 14:28:38, M-A wrote: > On 2010年07月16日 18:48:49, thakis wrote: > > M-A, say, did you still not land this? > > I had forgot, done. http://codereview.appspot.com/1671043 adds the update-index --refresh call to SendUpstream, as well.