Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 155530044: reflect: shorten Value to 2 words

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rsc
Modified:
11 years, 2 months ago
Reviewers:
Visibility:
Public.
reflect: shorten Value to 2 words This is an experiment. Method values are not implemented yet. They will have to set ptr = a pointer to a struct containing the method index and the original Value. That means Method will have to allocate, but that's not too big a loss. The new Value is more compact but a little slower: benchmark old MB/s new MB/s speedup BenchmarkGobDecode 52.14 51.21 0.98x BenchmarkGobEncode 58.12 56.42 0.97x BenchmarkJSONEncode 70.91 68.12 0.96x BenchmarkJSONDecode 18.98 18.29 0.96x BenchmarkTemplate 14.62 15.09 1.03x

Patch Set 1 #

Patch Set 2 : diff -r 2fafe84a2de77dfff6e9ed3b97d6cbfebf6d7c38 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a1d988c922a3f110cb949813ad10f274acfdeef9 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -367 lines) Patch
M src/reflect/export_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/reflect/makefunc.go View 1 4 chunks +8 lines, -7 lines 0 comments Download
M src/reflect/type.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/reflect/value.go View 1 2 87 chunks +312 lines, -355 lines 0 comments Download
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /