|
|
|
Created:
16 years, 1 month ago by Joel Stanley Modified:
16 years, 1 month ago CC:
skia-review_googlegroups.com Base URL:
http://skia.googlecode.com/svn/trunk/src/ Visibility:
Public. |
Exclude Android-only cpu-features.h from non-Android builds
This is needed when building Chromium for ARM.
Patch by Joel Stanley <joel@chromium.org>
Patch Set 1 #Patch Set 2 : '' #
Total comments: 6
Patch Set 3 : '' #
Total messages: 6
|
Joel Stanley
|
16 years, 1 month ago (2009年11月17日 14:19:47 UTC) #1 | |||||||||||||||||||||||||||||||
NACK for now. I need to chat to some people about this first.
LGTM. Mike Reed should probably give the final ok. http://codereview.appspot.com/154182/diff/8/1003 File core/SkBitmapProcState_filter.h (right): http://codereview.appspot.com/154182/diff/8/1003#newcode18 core/SkBitmapProcState_filter.h:18: #include <machine/cpu-features.h> Skia style != google3 style so one shouldn't reformat the include line. http://codereview.appspot.com/154182/diff/8/1001 File opts/SkBitmapProcState_opts_arm.cpp (right): http://codereview.appspot.com/154182/diff/8/1001#newcode18 opts/SkBitmapProcState_opts_arm.cpp:18: #include <machine/cpu-features.h> Probably best to match the indent here too. http://codereview.appspot.com/154182/diff/8/1002 File opts/SkBlitRow_opts_arm.cpp (right): http://codereview.appspot.com/154182/diff/8/1002#newcode19 opts/SkBlitRow_opts_arm.cpp:19: #include <machine/cpu-features.h> Probably best to match the indent here too.
http://codereview.appspot.com/154182/diff/8/1003 File core/SkBitmapProcState_filter.h (right): http://codereview.appspot.com/154182/diff/8/1003#newcode18 core/SkBitmapProcState_filter.h:18: #include <machine/cpu-features.h> On 2009年11月17日 23:39:25, agl1 wrote: > Skia style != google3 style so one shouldn't reformat the include line. Done. http://codereview.appspot.com/154182/diff/8/1001 File opts/SkBitmapProcState_opts_arm.cpp (right): http://codereview.appspot.com/154182/diff/8/1001#newcode18 opts/SkBitmapProcState_opts_arm.cpp:18: #include <machine/cpu-features.h> On 2009年11月17日 23:39:25, agl1 wrote: > Probably best to match the indent here too. Done. http://codereview.appspot.com/154182/diff/8/1002 File opts/SkBlitRow_opts_arm.cpp (right): http://codereview.appspot.com/154182/diff/8/1002#newcode19 opts/SkBlitRow_opts_arm.cpp:19: #include <machine/cpu-features.h> On 2009年11月17日 23:39:25, agl1 wrote: > Probably best to match the indent here too. Done.
If this is messing up your build, then it's probably ok to land it now. If Mike objects, we can always fix it later.
On 2009年11月19日 01:06:35, agl wrote: > If this is messing up your build, then it's probably ok to land it now. If Mike > objects, we can always fix it later. Thanks, that would be helpful. Are you able to commit for me? How do I go about getting it pulled into chrome's tree?