Issue 150060: minor tweaks to SSE2 code for -fPIC

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

(209)

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by Stephen White

Modified:
16 years, 2 months ago

Reviewers:
reed

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

gcc -fPIC requires that ebx not be clobbered, so restore it after calling cpuid.

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
src/opts/SkBlitRow_opts_SSE2.cpp	View	1 chunk	+10 lines, -4 lines	0 comments	Download

Total messages: 3

Stephen White

16 years, 2 months ago (2009年11月09日 03:34:00 UTC) #1

Stephen White

Diffs from skia root

16 years, 2 months ago (2009年11月09日 03:41:23 UTC) #2

Diffs from skia root

reed

LGTM

16 years, 2 months ago (2009年11月09日 19:54:07 UTC) #3

LGTM