|
|
|
A+C: add another email address for Emil Hessman
Patch Set 1 #Patch Set 2 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 http://code.google.com/p/go #Patch Set 3 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 http://code.google.com/p/go #Patch Set 4 : diff -r 3042795874453efa7be0a082f3f85118b9d06432 http://code.google.com/p/go #Patch Set 5 : diff -r 442fb01a3731b772e7e6f73b0edc4de2d81e4efc http://code.google.com/p/go #Total messages: 7
|
cehessman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go
|
11 years, 3 months ago (2014年09月23日 04:17:09 UTC) #1 |
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go
Is the @gmail.com one still the Google account? Otherwise the tools will complain if future reviews continue to come from the gmail address. You can specify two email addresses on a line if you'd like. See elsewhere in the file for an example.
On 2014年09月29日 19:47:30, bradfitz wrote: > Is the @gmail.com one still the Google account? Otherwise the tools will > complain if future reviews continue to come from the gmail address. > > You can specify two email addresses on a line if you'd like. See elsewhere in > the file for an example. I have signed the CLA with the new address, and my intention is to submit reviews with the new address only (effectively replacing the @gmail.com).
I think we still prefer having both, since you have historical hg commits under that previous email address. On Tue, Sep 30, 2014 at 3:13 AM, <c.emil.hessman@gmail.com> wrote: > On 2014年09月29日 19:47:30, bradfitz wrote: > >> Is the @gmail.com one still the Google account? Otherwise the tools >> > will > >> complain if future reviews continue to come from the gmail address. >> > > You can specify two email addresses on a line if you'd like. See >> > elsewhere in > >> the file for an example. >> > > I have signed the CLA with the new address, and my intention is to > submit reviews with the new address only (effectively replacing the > @gmail.com). > > https://codereview.appspot.com/143470043/ >
On 2014年09月30日 16:50:47, bradfitz wrote: > I think we still prefer having both, since you have historical hg commits > under that previous email address. OK. PTAL
LGTM On Wed, Oct 1, 2014 at 8:19 AM, <c.emil.hessman@gmail.com> wrote: > On 2014年09月30日 16:50:47, bradfitz wrote: > >> I think we still prefer having both, since you have historical hg >> > commits > >> under that previous email address. >> > > OK. > > PTAL > > > > https://codereview.appspot.com/143470043/ >
*** Submitted as https://code.google.com/p/go/source/detail?r=fba0ff340b22 *** A+C: add another email address for Emil Hessman LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/143470043 Committer: Brad Fitzpatrick <bradfitz@golang.org>