Issue 14028043: environs: move errors from errors package

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(154)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 14028043: environs: move errors from errors package

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rog

Modified:
12 years, 3 months ago

Reviewers:
mue , axw1 , mp+187990

Visibility:
Public.

environs: move errors from errors package The errors package should be reserved for errors that are widely applicable. Both "not bootstrapped" and "container not supported" are environs-specific and hence best defined there. Along the way, we change the errors to be more fit for purpose (no need for a nested error; no need for a custom message in ErrNotBootstrapped). BTW I'm not sure quite why we have a specific "containers unsupported" error, but I assume it will support some functionality as yet to arrive. https://code.launchpad.net/~rogpeppe/juju-core/423-move-errors/+merge/187990 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: move errors from errors package #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -82 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/bootstrap/bootstrap.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
A	environs/errors.go	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	environs/interface.go	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	environs/manual/bootstrap_test.go	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	errors/errors.go	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	errors/errors_test.go	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	provider/azure/environ.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	provider/azure/environ_test.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	provider/ec2/ec2.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	provider/local/environ.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	provider/maas/environ_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/openstack/provider.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	provider/state.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/state_test.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 3

rog

Please take a look.

12 years, 3 months ago (2013年09月27日 08:24:10 UTC) #1

Please take a look.

axw1

On 2013年09月27日 08:24:10, rog wrote: > Please take a look. LGTM

12 years, 3 months ago (2013年09月27日 08:30:07 UTC) #2

On 2013年09月27日 08:24:10, rog wrote:
> Please take a look.
LGTM

mue

LGTM, nice cleanup. Still not happy about the mix of own error types and using ...

12 years, 3 months ago (2013年09月27日 08:46:27 UTC) #3

LGTM, nice cleanup. Still not happy about the mix of own error types and using
of errors.New or fmt.Errorf, but that's not to be discussed here.