Issue 140065: Alternate alpha blending path

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(328)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 140065: Alternate alpha blending path

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by Stephen White

Modified:
16 years, 2 months ago

Reviewers:
reed

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

This patch implements alpha blending using SkDiv255Round(), which gives numerically exact values of (a / 255) (for values in the range 0..65025). This makes Skia's compositing operators match CG's results pixel for pixel, at a performance cost of a few more integer operations per pixel. For now, these changes are hidden behind #ifdef SK_USE_ACCURATE_BLENDING.

Patch Set 1 #

Patch Set 2 : Hide some more code behind #ifdefs #

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -7 lines)			Patch
include/core/SkColorPriv.h	View	3 chunks	+22 lines, -3 lines	0 comments	Download
src/core/SkBlitRow_D32.cpp	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
src/core/SkBlitter_ARGB32.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
src/core/SkScan_Antihair.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
src/core/SkXfermode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

Stephen White

16 years, 2 months ago (2009年10月26日 21:05:12 UTC) #1

Stephen White

16 years, 2 months ago (2009年10月26日 21:06:30 UTC) #2

Stephen White

Hide some more code behind #ifdefs

16 years, 2 months ago (2009年10月27日 03:04:50 UTC) #3

Hide some more code behind #ifdefs

reed

On 2009年10月27日 03:04:50, Stephen White wrote: > Hide some more code behind #ifdefs Lets talk ...

16 years, 2 months ago (2009年10月30日 19:13:48 UTC) #4

On 2009年10月27日 03:04:50, Stephen White wrote:
> Hide some more code behind #ifdefs
Lets talk more about these as a design discussion before narrowly having a
code-review.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b