Issue 13969043: environs/configstore: change file extension

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(98)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 13969043: environs/configstore: change file extension

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rog

Modified:
12 years, 3 months ago

Reviewers:
mp+187785, mue

Visibility:
Public.

environs/configstore: change file extension I think it's good to have *some* file extension, so we don't have to worry too much about whether we allow environment names to contain periods. The question remains: what extension to choose? Based on Dimiter's suggestion, I've chosen ".jenv", but others' mileages may vary. Let the bikeshedding begin. https://code.launchpad.net/~rogpeppe/juju-core/422-environ-info-extension/+merge/187785 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstore: change file extension #

Patch Set 3 : environs/configstore: change file extension #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/configstore/disk.go	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	environs/configstore/disk_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2

rog

Please take a look.

12 years, 3 months ago (2013年09月26日 13:48:55 UTC) #1

Please take a look.

mue

Big LGTM! https://codereview.appspot.com/13969043/diff/5001/environs/configstore/disk.go File environs/configstore/disk.go (right): https://codereview.appspot.com/13969043/diff/5001/environs/configstore/disk.go#newcode54 environs/configstore/disk.go:54: return filepath.Join(d.dir, "environments", envName+".jenv") Good choice. I ...

12 years, 3 months ago (2013年09月26日 13:52:51 UTC) #2

Big LGTM!
https://codereview.appspot.com/13969043/diff/5001/environs/configstore/disk.go
File environs/configstore/disk.go (right):
https://codereview.appspot.com/13969043/diff/5001/environs/configstore/disk.g...
environs/configstore/disk.go:54: return filepath.Join(d.dir, "environments",
envName+".jenv")
Good choice. I prefer names/extensions telling what the file is about more than
the format. Always hated all those .xml files.