|
|
|
net: ensure identical queries are not sent multiple times in unix stub resolver
Prevents non-rooted queries with > ndots dots from being tried twice on error.
Fixes issue 8616.
Benchmark results on linux/amd64
benchmark old ns/op new ns/op delta
BenchmarkGoLookupIPNoSuchHost 8212394 4413293 -46.26%
benchmark old allocs new allocs delta
BenchmarkGoLookupIPNoSuchHost 216 108 -50.00%
benchmark old bytes new bytes delta
BenchmarkGoLookupIPNoSuchHost 17460 8726 -50.02%
Patch Set 1 #Patch Set 2 : diff -r 25c3a04e7b95fac3cfe0bb1cb7d10b577674ec63 https://code.google.com/p/go #Patch Set 3 : diff -r 25c3a04e7b95fac3cfe0bb1cb7d10b577674ec63 https://code.google.com/p/go #
Total messages: 5
|
axaxs
Hello golang-codereviews@googlegroups.com (cc: mikioh.mikioh@gmail.com), I'd like you to review this change to https://code.google.com/p/go
|
11 years, 4 months ago (2014年08月29日 22:07:18 UTC) #1 | ||||||||||||||||||||||||
Hello golang-codereviews@googlegroups.com (cc: mikioh.mikioh@gmail.com), I'd like you to review this change to https://code.google.com/p/go
LGTM
LGTM
*** Submitted as https://code.google.com/p/go/source/detail?r=0ddf9c344a59 *** net: ensure identical queries are not sent multiple times in builtin stub resolver Prevents non-rooted queries with > ndots dots from being tried twice on error. Fixes issue 8616. Benchmark results on linux/amd64 benchmark old ns/op new ns/op delta BenchmarkGoLookupIPNoSuchHost 8212394 4413293 -46.26% benchmark old allocs new allocs delta BenchmarkGoLookupIPNoSuchHost 216 108 -50.00% benchmark old bytes new bytes delta BenchmarkGoLookupIPNoSuchHost 17460 8726 -50.02% LGTM=iant, mikioh.mikioh R=golang-codereviews, iant, mikioh.mikioh CC=golang-codereviews https://codereview.appspot.com/137870043 Committer: Mikio Hara <mikioh.mikioh@gmail.com>
This CL appears to have broken the windows-amd64-perf builder. See http://build.golang.org/log/686c587a39bfdf95a5a959df5ba9651d22ba3d54