Issue 13428043: environs/bootstrap: enable and fix tests

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(159)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 13428043: environs/bootstrap: enable and fix tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mue , mp+183194, fwereade

Visibility:
Public.

environs/bootstrap: enable and fix tests As jameinel suggests, it would be nice if go test at least printed a question mark when there are no tests to run. https://code.launchpad.net/~rogpeppe/juju-core/382-enable-bootstrap-tests/+merge/183194 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/bootstrap: enable and fix tests #

Patch Set 3 : environs/bootstrap: enable and fix tests #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/bootstrap/bootstrap.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/bootstrap/bootstrap_test.go	View	1 2	6 chunks	+20 lines, -0 lines	0 comments	Download
M	environs/localstorage/storage.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/maas/environ_test.go	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4

rog

Please take a look.

12 years, 4 months ago (2013年08月30日 14:30:22 UTC) #1

Please take a look.

fwereade

LGTM

12 years, 4 months ago (2013年08月30日 14:31:21 UTC) #2

LGTM

mue

LGTM

12 years, 4 months ago (2013年08月30日 14:32:46 UTC) #3

LGTM

rog

Please take a look.

12 years, 4 months ago (2013年08月30日 16:32:47 UTC) #4

Please take a look.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b