|
|
|
Created:
11 years, 4 months ago by haypo_gmail Modified:
11 years, 3 months ago Reviewers:
yselivanov CC:
haypo_gmail, GvR Visibility:
Public. |
BaseEventLoop.call_exception_handler() now accepts a "source" key
Patch Set 1 #
Total messages: 1
|
yselivanov
Hm. I don't like this source / source._source_traceback logic in `BaseEventLoop.default_exception_handler()`. Simply because it's an ...
|
11 years, 3 months ago (2014年09月12日 22:30:47 UTC) #1 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Hm.
I don't like this source / source._source_traceback logic in
`BaseEventLoop.default_exception_handler()`. Simply because it's an
undocumented attribute of 'context' dict with an undocumented attribute
'_source_traceback'. People may start copying&pasting this in order to have
custom exception handlers.
Can you just call it like this:
call_exception_handler({
...,
'source_traceback': self.source_traceback
})
?
Yes, sometimes you'll have Nones in there, but what's the problem with that?
I'd also add 'source_traceback' to the docstring of 'call_exception_handler()'
method.