|
|
|
Created:
11 years, 4 months ago by dupoxy Modified:
11 years ago Reviewers:
CC:
golang-codereviews, adg Visibility:
Public. |
go.tools/godoc: Use relative font sizes
Fixes Issue 6150
Patch Set 1 #Patch Set 2 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #Patch Set 3 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #Patch Set 4 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #Patch Set 5 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #
Created: 11 years, 4 months ago
(Patch set is too large to download)
Total messages: 7
|
dupoxy
I did run ./bake.sh but codereview is saying that the resulting static.go file is to ...
|
11 years, 4 months ago (2014年08月30日 19:56:25 UTC) #1 | ||||||||||||||
I did run ./bake.sh but codereview is saying that the resulting static.go file is to large to upload ...
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
Inconsistencies introduced by this change: (old vs new) - Table of contents font size too small [image: Inline images 3] [image: Inline images 4] - Also in package index: [image: Inline images 5] [image: Inline images 7] Otherwise it looks okay!
Hello golang-codereviews@googlegroups.com, adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
There are still some inconsistencies. Actually, more than before: both the indices and all pre-formatted blocks are slightly wider. See the attached screenshots. I'm actually not opposed to this change. On my screen it might even make the text a little clearer. But I'd like a second opinion from someone else before proceeding. (cc'd a couple of likely candidates) (Unless you can tweak it again to make it exactly the same. I understand that this is CSS and so that's not necessarily as easy as it sounds.)
Here are the before/after godoc binaries for darwin/amd64 if someone else wants to have a look around.
R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/133380043 is best) in the description in your new CL. Thanks very much.