Issue 13321046: environs/sshstorage: fix for non-bash shells

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(90)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 13321046: environs/sshstorage: fix for non-bash shells

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rog

Modified:
12 years, 3 months ago

Reviewers:
mp+185803, natefinch

Visibility:
Public.

environs/sshstorage: fix for non-bash shells The tests can fail when run in an environment where $SHELL is not /bin/bash. https://code.launchpad.net/~rogpeppe/juju-core/397-fix-sshstorage-for-non-bash/+merge/185803 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/sshstorage/storage.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1

natefinch

LGTM

12 years, 3 months ago (2013年09月16日 13:40:00 UTC) #1

LGTM