Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(316)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 130560043: code review 130560043: doc/cmd.html: close a tag.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Oling Cat
Modified:
11 years, 4 months ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.
doc/cmd.html: close a tag.

Patch Set 1 #

Patch Set 2 : diff -r 528863ac401ff24391b01bbaf88080e5b85c0534 https://code.google.com/p/go #

Patch Set 3 : diff -r 528863ac401ff24391b01bbaf88080e5b85c0534 https://code.google.com/p/go #

Created: 11 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/cmd.html View 1 1 chunk +1 line, -1 line 0 comments Download
Total messages: 4
|
Oling Cat
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2014年08月26日 04:28:07 UTC) #1
Hello golang-codereviews@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go 
Sign in to reply to this message.
bradfitz
LGTM On Mon, Aug 25, 2014 at 9:28 PM, <olingcat@gmail.com> wrote: > Reviewers: golang-codereviews, > ...
11 years, 4 months ago (2014年08月26日 12:26:05 UTC) #2
LGTM
On Mon, Aug 25, 2014 at 9:28 PM, <olingcat@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> doc/cmd.html: close a tag.
>
> Please review this at https://codereview.appspot.com/130560043/
>
> Affected files (+1, -1 lines):
> M doc/cmd.html
>
>
> Index: doc/cmd.html
> ===================================================================
> --- a/doc/cmd.html
> +++ b/doc/cmd.html
> @@ -65,7 +65,7 @@
> <td><a href="//godoc.org/code.google.com/p/go.tools/cmd/cover/">
> cover</a></td>
> <td>&nbsp;&nbsp;&nbsp;&nbsp;</td>
> <td>Cover is a program for creating and analyzing the coverage profiles
> -generated by <code>"go test -coverprofile"</code>.
> +generated by <code>"go test -coverprofile"</code>.</td>
> </tr>
>
> <tr>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=47de34bbcca1 *** doc/cmd.html: close a tag. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/130560043 Committer: ...
11 years, 4 months ago (2014年08月26日 12:26:59 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=47de34bbcca1 ***
doc/cmd.html: close a tag.
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/130560043
Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.
gobot
This CL appears to have broken the linux-arm-panda builder. See http://build.golang.org/log/bb5466f9b209b3309bdf80f0454ef8f8021a61ec
11 years, 4 months ago (2014年08月26日 12:44:54 UTC) #4
This CL appears to have broken the linux-arm-panda builder.
See http://build.golang.org/log/bb5466f9b209b3309bdf80f0454ef8f8021a61ec 
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /