|
|
|
Created:
16 years, 3 months ago by nickcarter Modified:
16 years, 3 months ago CC:
evanm Visibility:
Public. |
Make upload.py use --no-renames. This generates more SVN-like patches,
ones that are broken down into add+delete operations. The result will
be reviews that are more consistent with what gcl produces on svn.
Also, fix the 'git show' command for renames (renames shouldn't happen
with --no-renames) where there is no corresponding edit in the diff.
Previously this would crash.
Patch Set 1 #Total messages: 3
|
nickcarter
To see what renames look like in Rietveld before and after this change, see the ...
|
16 years, 3 months ago (2009年09月25日 22:58:04 UTC) #1 |
To see what renames look like in Rietveld before and after this change, see the various patch sets of the test issue: http://codereview.chromium.org/246010/show
Actually, I realized that --no-renames means that we lose history, particularly in the edit case. That's actually pretty valuable. So the solution will be something more like adding "D" deletion records for the old filenames in 'renames' to the svn diff. I'll code that up.
Since this file is in Rietveld, you'll need to make the patch against Rietveld (static/upload.py in their tree). I can review+commit your patches on that.