|
|
|
Created:
12 years, 5 months ago by PhistucK Modified:
12 years, 5 months ago CC:
codereview-list_googlegroups.com Visibility:
Public. |
The prerender directive is included twice in the diff pages.
Removed the directive from a common template and moved it into the various diff templates instead. Now there is only one directive per page.
This fixes issue 447.
https://code.google.com/p/rietveld/issues/detail?id=447
Patch Set 1 #Patch Set 2 : Removed an unrelated change #
Total comments: 2
Total messages: 2
|
PhistucK
|
12 years, 5 months ago (2013年08月02日 20:30:36 UTC) #1 | ||||||||||||||||||||||||||||||||||||||||||
sorry for the delay... https://codereview.appspot.com/12351044/diff/4001/templates/diff_navigation.html File templates/diff_navigation.html (right): https://codereview.appspot.com/12351044/diff/4001/templates/diff_navigation.h... templates/diff_navigation.html:4: href="{%ifequal view_style 'patch'%}{%url codereview.views.patch issue.key.id,patchset.key.id,patch.next.key.id%}{%else%}{%url codereview.views.diff issue.key.id,patchset.key.id,patch.next.filename%}{%endifequal%}{%urlappend_view_settings%}"></link> Since diff_navigation.html is only included in diff.html view_style should always be "diff" here. https://codereview.appspot.com/12351044/diff/4001/templates/patch.html File templates/patch.html (right): https://codereview.appspot.com/12351044/diff/4001/templates/patch.html#newcod... templates/patch.html:108: href="{%ifequal view_style 'patch'%}{%url codereview.views.patch issue.key.id,patchset.key.id,patch.next.key.id%}{%else%}{%url codereview.views.diff issue.key.id,patchset.key.id,patch.next.filename%}{%endifequal%}{%urlappend_view_settings%}"></link> If I see this correctly, view_style is always "patch" here.