Issue 12349043: all: remove unnecessary panics

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(108)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 12349043: all: remove unnecessary panics

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 5 months ago

Reviewers:
mue , dimitern , mp+178283

Visibility:
Public.

all: remove unnecessary panics With Go1.1, these panics are no longer necessary. There are only three now left in the tree. https://code.launchpad.net/~rogpeppe/juju-core/356-remove-unreachable/+merge/178283 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: remove unnecessary panics #

Patch Set 3 : all: remove unnecessary panics #

Patch Set 4 : all: remove unnecessary panics #

Patch Set 5 : all: remove unnecessary panics #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -35 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/synctools_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cmd/jujud/agent.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	cmd/jujud/deploy_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	container/lxc/lxc.go	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	rpc/rpc_test.go	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	rpc/server.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	state/minimumunits.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	state/multiwatcher/multiwatcher.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	state/presence/presence.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	state/watcher.go	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	state/watcher/watcher.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	utils/fslock/fslock.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/environ.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/firewaller/firewaller.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/provisioner/provisioner_task.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/resumer/resumer.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/runner.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/uniter/charm/charm.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/uniter/filter.go	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	worker/uniter/modes.go	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	worker/uniter/uniter.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7

rog

Please take a look.

12 years, 5 months ago (2013年08月02日 12:43:04 UTC) #1

Please take a look.

dimitern

Yay! LGTM! How about method expressions though?

12 years, 5 months ago (2013年08月02日 12:45:47 UTC) #2

Yay! LGTM!
How about method expressions though?

dimitern

Yay! LGTM! How about method expressions though?

12 years, 5 months ago (2013年08月02日 12:45:47 UTC) #3

Yay! LGTM!
How about method expressions though?

rog

Please take a look.

12 years, 5 months ago (2013年08月02日 12:50:17 UTC) #4

Please take a look.

mue

LGTM

12 years, 5 months ago (2013年08月02日 12:50:39 UTC) #5

LGTM

rog

Please take a look.

12 years, 5 months ago (2013年08月02日 14:06:58 UTC) #6

Please take a look.

rog

Please take a look.

12 years, 5 months ago (2013年08月02日 14:07:52 UTC) #7

Please take a look.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b